Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(45345): noImplicitOverride doesn't work if member is defined in multiple interfaces #45352

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #45345

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 7, 2021
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 9, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.4 on this PR at 58a924d. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #45384 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 9, 2021
Component commits:
58a924d fix(45345): throw an error on overridden member that is defined in multiple interfaces
@DanielRosenwasser DanielRosenwasser merged commit ad894f7 into microsoft:main Aug 10, 2021
DanielRosenwasser pushed a commit that referenced this pull request Aug 10, 2021
Component commits:
58a924d fix(45345): throw an error on overridden member that is defined in multiple interfaces

Co-authored-by: Oleksandr T <[email protected]>
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noImplicitOverride doesn't work if member is defined in multiple interfaces
4 participants